Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyperHTML.adopt(liveNode) #185

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

hyperHTML.adopt(liveNode) #185

wants to merge 3 commits into from

Conversation

WebReflection
Copy link
Owner

@WebReflection WebReflection commented Feb 5, 2018

After the introduction of viperHTML.adoptable = true, capable of creating a compact and compression friendly way to delimit all interpolations of a template literals, hyperHTML would like to re-introduce this ability lost wtih v2 release because unstable.

All the basics are working but there are still two cases I cannot code cover because failing:

  • nodes with just textContent behaves differently, when text action is used the adoption shuold work properly
  • when there are levels outside those already explored, findNode(...) internal function does not handle well the level variable together with the index

Once these two outstanding bugs are fixed, I will think about releasing v3 to include adopt within the library and branch out v2 for eventual emergency fixes.

@WebReflection WebReflection self-assigned this Feb 5, 2018
@WebReflection WebReflection mentioned this pull request Feb 5, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 4f1d747 on re-adopt into c689e81 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants