Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply new overflow menu design - closes #3104 #3105

Merged
merged 1 commit into from
Aug 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 18 additions & 55 deletions static/css/app.css
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,6 @@ h6 {
display: flex;
flex-direction: row;
align-items: center;
justify-content: center;
padding: 0;
list-style-type: none;
}
Expand All @@ -281,77 +280,41 @@ h6 {
color: #fff;
}

/* Older overflow menus use anchors rather than buttons inside list items */
a.overflow-menu-item {
width: 100%;
height: 4rem;
margin: 0;
padding: 0 1rem;
font-size: 1.6rem;
color: #fff;
text-decoration: none;
box-sizing: border-box;
}

.overflow-menu-item button:hover,
.overflow-menu-item button:active {
.overflow-menu-item button:active,
a.overflow-menu-item:hover,
a.overflow-menu-item:active {
background-color: #3a607c;
}

.overflow-menu-item button img {
.overflow-menu-item img {
width: 1.6rem;
height: 1.6rem;
padding: 0.8rem;
margin-right: 0.5rem;
}

.overflow-menu-item button span {
flex: 1;
text-align: left;
font-size: 1.6rem;
margin-left: 1rem;
}

/* Old Overflow Menu (to be deprecated) */
#overflow-menu {
position: fixed;
bottom: 9rem;
right: 3rem;
background-color: #5288af;
color: white;
padding: 1rem 0;
border-radius: 0.5rem;
transform: scale(1);
transition: transform 0.25s ease;
transform-origin: bottom right;
}

#overflow-menu::after {
content: '';
position: absolute;
bottom: -1rem;
right: 1rem;
border-width: 1rem 1rem 0;
border-style: solid;
border-color: #5288af transparent;
display: block;
width: 0;
}

#overflow-menu.hidden {
transform: scale(0);
}

#overflow-menu > a:link,
#overflow-menu > a:visited,
#overflow-menu > a:hover,
#overflow-menu > a:active {
color: #fff;
font-size: 2rem;
display: block;
padding: 0.4rem 1rem;
text-decoration: none;
}

#overflow-menu > a:hover {
background-color: #4d80a5;
}

#overflow-menu > a:active {
background-color: #48779a;
}

#overflow-menu > a > img {
height: 2rem;
padding-right: 1rem;
margin-bottom: -0.3rem;
right: 2rem;
}

/* Dialog */
Expand Down
2 changes: 1 addition & 1 deletion static/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,7 @@ <h3 class="logs-header" data-l10n-id="logs"></h3>
class="hidden back-button icon-button"
data-l10n-id="back-button"
></a>
<div id="overflow-menu" class="hidden"></div>
<div id="overflow-menu" class="hidden overflow-menu above"></div>

<!-- Message area -->
<div id="message-area" class="hidden"></div>
Expand Down
1 change: 1 addition & 0 deletions static/js/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,7 @@ const App = {

for (const link of links) {
const element = document.createElement('a');
element.classList.add('overflow-menu-item');
element.innerText = link.name;

if (link.listener) {
Expand Down
Loading