Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #3108 - fixes #3122 back button bug #3123

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

benfrancis
Copy link
Member

Unfortunately the fix for #3056 caused #3122.

We'll have to find another way to fix #3056.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.90%. Comparing base (d6f1bf4) to head (fe2b50d).

❗ Current head fe2b50d differs from pull request most recent head aa40b24. Consider uploading reports for the commit aa40b24 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3123   +/-   ##
=======================================
  Coverage   62.90%   62.90%           
=======================================
  Files         118      118           
  Lines        9014     9014           
  Branches     1709     1709           
=======================================
  Hits         5670     5670           
  Misses       3098     3098           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benfrancis benfrancis merged commit 6b5fb8f into WebThingsIO:master Mar 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web UI shows "No devices yet" briefly during launch
3 participants