Rebase against latest upstream and patch to fix build workflow of zwave-adapter #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update 03009499.xml
Update 03009497.xml
Revert "Add basic command class to Aeotec switches and dimmers"
Add Minoston MS11Z (NEI)
Closed the Product element and added MetaData.
Create ms11z.xml
Update manufacturer_specific.xml
Adding Inovelli LZW45 Light Strip
Add Hank smartplug so08 configuration
…hermostat Use supervision to set thermostat setpoint
…n_thermostat_mode Making use of the Supervision CC to set the thermostat mode.
…n_Switch_Binary Supervision CC support for SwitchBinary
…n_Switch_MultiLevel Supervision CC support for SwitchMultiLevel
Added support for Heatit ZM Single Relay 16A
new device fibaro/fgwceu201 - Fibaro Walli Controller
Second fix of lifeline group 1.1 receives no update. Tested and works as expected
Removed name
Update ZMNHCDx.xml
add notice
This was referenced Apr 11, 2024
tim-hellhake
approved these changes
Apr 18, 2024
|
(I rebased this after merging to not use a merge commit, the original result of this merge is in the master-backup branch) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Z-Wave add-on is failing to build on GitHub Actions because of a bug in openzwave which reveals itself when using more recent compilers.
This PR rebases our fork of openzwave on the latest master from upstream and applies a patch from OpenZWave#2647 which actually fixes the compile bug (but hasn't been accepted upstream because the upstream repo is now unmaintained).
Note that this upgrade may only be strictly necessary for the build workflow on GitHub Actions which compiles openzwave on ubuntu-latest. The build step in the release workflow uses the build.sh script from this repo which builds openzwave in a docker container which presumably has an older base OS because it compiles openzwave successfully. We may want to consider making these more consistent in the future.
If this PR is merged we should update the moziot tag (which the build process of the add-on uses) and test thoroughly before pushing out a new release of the add-on.