-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup-and-update-readme #12
base: main
Are you sure you want to change the base?
Conversation
Shreyas281299
commented
May 17, 2024
- Cleanup and updated readme.
2. Get access token for users registered with Webex Calling. If you don't have an account request for a sandbox - https://developer.webex.com/docs/developer-sandbox-guide | ||
3. In "js/app.js", put the access tokens (line 126, 128) | ||
4. Run `yarn start` | ||
5. Navigate to [http://127.0.0.1:9000](http://127.0.0.1:9000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to specify here that mytrips.html is one page and other one is agent.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
LICENSE.md
Outdated
@@ -1,81 +0,0 @@ | |||
CISCO SAMPLE CODE LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should find what the template's license is and add it instead, I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamweeks - Looking to know your thoughts on this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkesavan13 I believe @ashjorda has updated this repo with the correct license file needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shreyas281299 - In which case, we shouldn't remove this file. Please add it back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashjorda has already removed this duplicate lisence.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment. We can discuss that with Adam Weeks if required
callerNumber.innerText = CallerIdEmitter.callerId.num; | ||
}); | ||
|
||
incomingCall.on("remote_media", (track) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also should add an event listener for hold success, hold error, resume success and resume failure for both the call objects in this file.