Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (bug): Display issues in language switcher #2167

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

meel-hd
Copy link
Contributor

@meel-hd meel-hd commented Sep 23, 2024

Proposed changes

  • Gave more width to the language switcher on mobile.
  • Fixed "Help Translate" overlapping
  • Show language name if it fits or show ellipses... to differentiate between English and English (United Kingdom), etc.

Closes: Displaying bugs of the unfolding language switcher #2158

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

Preview

image

- Gave more width to the switcher on mobile.
- Fixed "Help Translate" overlaping
- Show language name if it fits or show ellipseses... to differentiate between English and English (United Kingdom), etc.

Closes: Displaying bugs of the unfolding language switcher WeblateOrg#2158
@meel-hd meel-hd requested a review from nijel September 23, 2024 10:29
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.71%. Comparing base (f201abe) to head (9eda469).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2167      +/-   ##
==========================================
+ Coverage   82.67%   82.71%   +0.03%     
==========================================
  Files          26       26              
  Lines        2904     2904              
  Branches      431      431              
==========================================
+ Hits         2401     2402       +1     
+ Misses        400      399       -1     
  Partials      103      103              

@nijel
Copy link
Member

nijel commented Sep 23, 2024

Looks good. Can you please apply the same changes to style-rtl.css which is used for RTL languages?

@meel-hd
Copy link
Contributor Author

meel-hd commented Sep 23, 2024

Done

@nijel nijel merged commit 0a7d4cb into WeblateOrg:main Sep 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants