Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid cascading on deletion #2219

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: avoid cascading on deletion #2219

merged 1 commit into from
Oct 18, 2024

Conversation

nijel
Copy link
Member

@nijel nijel commented Oct 18, 2024

Proposed changes

This is not really desired, we do not want to delete suscriptions on package removal.

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel self-assigned this Oct 18, 2024
@nijel nijel enabled auto-merge (rebase) October 18, 2024 09:42
@nijel nijel disabled auto-merge October 18, 2024 09:44
This is not really desired, we do not want to delete suscriptions on package removal.
@nijel nijel enabled auto-merge (rebase) October 18, 2024 09:44
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.47%. Comparing base (e38a1cc) to head (feec23b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2219   +/-   ##
=======================================
  Coverage   82.47%   82.47%           
=======================================
  Files          30       30           
  Lines        3219     3219           
  Branches      294      294           
=======================================
  Hits         2655     2655           
  Misses        459      459           
  Partials      105      105           

@nijel nijel merged commit 8a62c72 into main Oct 18, 2024
14 of 16 checks passed
@nijel nijel deleted the protect branch October 18, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant