Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce djlint #2257

Merged
merged 5 commits into from
Oct 23, 2024
Merged

introduce djlint #2257

merged 5 commits into from
Oct 23, 2024

Conversation

nijel
Copy link
Member

@nijel nijel commented Oct 23, 2024

Proposed changes

Apply consistent formatting and style to Django templates.

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

<div class="wrap features">
<div class="f-box">
<div class="icon">
<img src="{% static "img/icon-software.svg" %}" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

<div class="title">{% trans "Choose your amount in EUR" %}</div>
<form method="post">
{% csrf_token %}
<input type="number"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

</div>
<div class="f-box">
<div class="icon">
<img src="{% static "img/icon-earth.svg" %}" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

<div class="f-box">
<a href="https://docs.weblate.org/en/latest/admin/access.html">
<div class="icon">
<img src="{% static "img/icon-control.svg" %}" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

</div>
<div class="f-box">
<div class="icon">
<img src="{% static "img/icon-finance.svg" %}" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

<div class="f-box">
<a href="https://docs.weblate.org/en/latest/user/translating.html#variants">
<div class="icon">
<img src="{% static "img/icon-magnet.svg" %}" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

<div class="f-box">
<a href="https://docs.weblate.org/en/latest/workflows.html#source-quality-gateway">
<div class="icon">
<img src="{% static "img/icon-layers.svg" %}" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

<div class="f-box">
<a href="https://docs.weblate.org/en/latest/admin/machine.html">
<div class="icon">
<img src="{% static "img/icon-translate-variant.svg" %}" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

<div class="f-box">
<a href="https://docs.weblate.org/en/latest/admin/projects.html">
<div class="icon">
<img src="{% static "img/icon-file-tree-outline.svg" %}" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

<div class="f-box">
<a href="https://docs.weblate.org/en/latest/user/translating.html#keyboard-shortcuts">
<div class="icon">
<img src="{% static "img/icon-keyboard-outline.svg" %}" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

@nijel nijel enabled auto-merge (rebase) October 23, 2024 14:03
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.49%. Comparing base (da22d93) to head (14d2cbc).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2257   +/-   ##
=======================================
  Coverage   82.49%   82.49%           
=======================================
  Files          35       35           
  Lines        3747     3747           
  Branches      341      341           
=======================================
  Hits         3091     3091           
  Misses        526      526           
  Partials      130      130           

@nijel nijel merged commit 16edbb0 into main Oct 23, 2024
17 of 18 checks passed
@nijel nijel deleted the djlint branch October 23, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant