Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manually download fonts instead of yarn #2413

Merged
merged 1 commit into from
Dec 19, 2024
Merged

feat: manually download fonts instead of yarn #2413

merged 1 commit into from
Dec 19, 2024

Conversation

nijel
Copy link
Member

@nijel nijel commented Dec 19, 2024

Proposed changes

  • the npm packages are outdated
  • we do not need anything besides woff2

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

- the npm packages are outdated
- we do not need anything besides woff2
@nijel nijel enabled auto-merge (rebase) December 19, 2024 13:46
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.74%. Comparing base (0df8d23) to head (d22cc1a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2413   +/-   ##
=======================================
  Coverage   79.74%   79.74%           
=======================================
  Files          56       56           
  Lines        4874     4874           
  Branches      477      477           
=======================================
  Hits         3887     3887           
  Misses        829      829           
  Partials      158      158           

@nijel nijel merged commit 8199f22 into main Dec 19, 2024
18 of 19 checks passed
@nijel nijel deleted the fonts branch December 19, 2024 13:48
@nijel nijel self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant