-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
일정 생성 Domain 모듈 작성 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📄 Image Server Jacoco Coverage Report
|
KIMSEI1124
added
Type: ✨ Feature
새로운 기능 추가
Status: Review Needed
Module: Core Server
labels
Sep 22, 2024
jiwon83
added
Priority: 🙏 P1
꼭 반영해주세요 (Request changes)
Module: Jpa Calendar Domain
and removed
Type: ✨ Feature
새로운 기능 추가
Module: Core Server
Status: Review Needed
labels
Sep 22, 2024
KIMSEI1124
requested changes
Sep 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
궁금한점 코멘트로 달아놨습니다!
...n/wypl-core/src/main/java/com/wypl/wyplcore/schedule/data/request/ScheduleCreateRequest.java
Show resolved
Hide resolved
...n/jpa-calendar-domain/src/main/java/com/wypl/jpacalendardomain/calendar/domain/Schedule.java
Outdated
Show resolved
Hide resolved
...n/jpa-calendar-domain/src/main/java/com/wypl/jpacalendardomain/calendar/domain/Calendar.java
Outdated
Show resolved
Hide resolved
- calendar -> calendar_tbl Resolves: #14
KIMSEI1124
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
📄 Image Server Jacoco Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Module: Core Server
Module: Jpa Calendar Domain
Priority: 🙏 P1
꼭 반영해주세요 (Request changes)
Status: Review Needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 개요
✅ PR 체크리스트
🚀 상세 작업 내용
Request class
Convertible 인터페이스
Mapper class
📁 ETC