Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

일정 생성 Domain 모듈 작성 #25

Merged
merged 12 commits into from
Sep 22, 2024
Merged

일정 생성 Domain 모듈 작성 #25

merged 12 commits into from
Sep 22, 2024

Conversation

jiwon83
Copy link
Member

@jiwon83 jiwon83 commented Sep 22, 2024

📑 개요

✅ PR 체크리스트


  • 🔀 PR 제목의 형식을 잘 작성했나요?
  • 💯 테스트는 잘 통과했나요?
  • 🏗️ 빌드는 성공했나요?
  • 🧹 불필요한 코드는 제거했나요?
  • 💭 이슈는 등록했나요?
  • 🏷️ 라벨은 등록했나요?

🚀 상세 작업 내용



Request class

public record ScheduleRequest (

        String title,

        ... 생략
) implements ConvertibleSchedule {
        @Override
        public String getTitle() {
                return this.title;
        }
       ... 생략

}

Convertible 인터페이스

public interface ConvertibleSchedule {

    String getTitle();

   ... 생략
}

Mapper class

public class ScheduleMapper {

    public static Schedule toJpaSchedule(ConvertibleSchedule convertibleSchedule, ScheduleInfo scheduleInfo) {
        return Schedule.builder()
                .scheduleInfo(scheduleInfo)
                .title(convertibleSchedule.getTitle())
                ... 생략
                .build();
    }

📁 ETC


@jiwon83 jiwon83 changed the base branch from main to dev September 22, 2024 10:07
Copy link

📄 Image Server Jacoco Coverage Report

Overall Project 88.81% 🍏

There is no coverage information present for the Files changed

Copy link
Member

@KIMSEI1124 KIMSEI1124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

궁금한점 코멘트로 달아놨습니다!

Copy link
Member

@KIMSEI1124 KIMSEI1124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

📄 Image Server Jacoco Coverage Report

Overall Project 88.81% 🍏

There is no coverage information present for the Files changed

@jiwon83 jiwon83 merged commit 52a65e0 into dev Sep 22, 2024
3 checks passed
@KIMSEI1124 KIMSEI1124 deleted the feat/#14 branch October 14, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants