Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Weather API를 연동 #37

Merged
merged 17 commits into from
Oct 17, 2024
Merged

Open Weather API를 연동 #37

merged 17 commits into from
Oct 17, 2024

Conversation

KIMSEI1124
Copy link
Member

@KIMSEI1124 KIMSEI1124 commented Oct 6, 2024

📑 개요

✅ PR 체크리스트


  • 🔀 PR 제목의 형식을 잘 작성했나요?
  • 💯 테스트는 잘 통과했나요?
  • 🏗️ 빌드는 성공했나요?
  • 🧹 불필요한 코드는 제거했나요?
  • 💭 이슈는 등록했나요?
  • 🏷️ 라벨은 등록했나요?

🚀 상세 작업 내용


Git

  • Core Server Git Submodule 추가

Openweather Client

  • Openweather Client 코드 작성
  • 날씨 상태에 따른 분류
  • 날씨 조회하는 도시 목록 작성
  • 테스트 코드 작성

📁 ETC


colsed: #31

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Resolvers: #31
Copy link

github-actions bot commented Oct 6, 2024

📄 Image Server Jacoco Coverage Report

Overall Project 88.81% 🍏

There is no coverage information present for the Files changed

@KIMSEI1124 KIMSEI1124 requested a review from sjhjack October 6, 2024 07:15
@KIMSEI1124 KIMSEI1124 linked an issue Oct 6, 2024 that may be closed by this pull request
Copy link
Contributor

@sjhjack sjhjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~!!

from to fromCity
Copy link

📄 Image Server Jacoco Coverage Report

Overall Project 88.81% 🍏

There is no coverage information present for the Files changed

Copy link

📄 Image Server Jacoco Coverage Report

Overall Project 88.81% 🍏

There is no coverage information present for the Files changed

Copy link

📄 Image Server Jacoco Coverage Report

Overall Project 88.81% 🍏

There is no coverage information present for the Files changed

Copy link

📄 Image Server Jacoco Coverage Report

Overall Project 88.81% 🍏

There is no coverage information present for the Files changed

Copy link

📄 Image Server Jacoco Coverage Report

Overall Project 88.81% 🍏

There is no coverage information present for the Files changed

1 similar comment
Copy link

📄 Image Server Jacoco Coverage Report

Overall Project 88.81% 🍏

There is no coverage information present for the Files changed

Copy link
Member Author

@KIMSEI1124 KIMSEI1124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjhjack

주신 코멘트를 모두 확인하였고, 수정하였습니다!

Copy link
Contributor

@sjhjack sjhjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

@KIMSEI1124 KIMSEI1124 merged commit 45e2a5f into dev Oct 17, 2024
3 checks passed
@KIMSEI1124 KIMSEI1124 deleted the feat/#31 branch October 17, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Open Weather API를 연동한다.
2 participants