Added more translations to Czech language #448
Conversation
app/src/main/res/values/strings.xml
Outdated
| @@ -491,7 +491,7 @@ | |||
| <string name="notification_text_max">[SPEED] \n ⭐ %1$.0f k/h \n 🔥 %2$.0f top \n 🙈 %3$.0f avg \n\n[POWER] \n 💧 %4$d %% \n ⚡ %5$.2f V \n 💪 %6$.0f W \n ❄ %7$d °C \n\n[TRIP] \n 👣 %8$.1f km</string> | |||
| <string name="notification_text_alarm">[DATA] \n - %1$.0f k/h \n - %2$.1f A \n - %3$.2f V \n - %4$d %% \n - %5$d °C</string> | |||
| <string name="notification_text_alarm_not">Alarm data: %1$.0f k/h | %2$.1f A | %3$.2f V | %4$d %% | %5$d °C</string> | |||
| <string name="notification_text_not">%1$.0f km/h | %2$d %% | %3$.0f W | %4$d°C | %5$.3f km</string> | |||
| <string name="notification_text_not" translatable="false">%1$.0f km/h | %2$d %% | %3$.0f W | %4$d°C | %5$.3f km</string> | |||
There was a problem hiding this comment.
Why? It is available in other languages =)
There was a problem hiding this comment.
How it can be translated?
In optimal case it should be built dynamically according user's settings (whether they prefer miles per hour or degrees of Fahrenheit or metric system).
There was a problem hiding this comment.
It would make sense to create some kind of builder for such a notifications that would take into account options (miles vs kilometers) and translated units (km vs км). I can prepare some proof of concept if you are interested.
There was a problem hiding this comment.
it should be in a separate PR
There was a problem hiding this comment.
How it can be translated?
In optimal case it should be built dynamically according user's settings (whether they prefer miles per hour or degrees of Fahrenheit or metric system).
If you don't want this line to be translated in Czech, you can just remove it from Czech locale
app/src/main/res/values/strings.xml
Outdated
| <string name="notification_text">• %1$.1f km/h • %2$d%% • %3$d°C • %4$.1f km •</string> | ||
| <string name="notification_text_ajdm_theme">%1$.1f km/h | %2$d%% | %3$d°C | %4$.1f km</string> | ||
| <string name="notification_text" translatable="false">• %1$.1f km/h • %2$d%% • %3$d°C • %4$.1f km •</string> | ||
| <string name="notification_text_ajdm_theme" translatable="false">%1$.1f km/h | %2$d%% | %3$d°C | %4$.1f km</string> |
There was a problem hiding this comment.
It is available in other languages (ru & uk)
|
Of course, it makes sense.
I'll create draft PR for proof of concept and if like it, I'll finish it.
In this PR I'll remove all translatable="false" changes and leave Czech
translations only.
Dne út 19. 9. 2023 19:44 uživatel Pavel Yakovlev ***@***.***>
napsal:
… ***@***.**** commented on this pull request.
------------------------------
In app/src/main/res/values/strings.xml
<#448 (comment)>
:
> @@ -491,7 +491,7 @@
<string name="notification_text_max">[SPEED] \n ⭐ %1$.0f k/h \n 🔥 %2$.0f top \n 🙈 %3$.0f avg \n\n[POWER] \n 💧 %4$d %% \n ⚡ %5$.2f V \n 💪 %6$.0f W \n ❄ %7$d °C \n\n[TRIP] \n 👣 %8$.1f km</string>
<string name="notification_text_alarm">[DATA] \n - %1$.0f k/h \n - %2$.1f A \n - %3$.2f V \n - %4$d %% \n - %5$d °C</string>
<string name="notification_text_alarm_not">Alarm data: %1$.0f k/h | %2$.1f A | %3$.2f V | %4$d %% | %5$d °C</string>
- <string name="notification_text_not">%1$.0f km/h | %2$d %% | %3$.0f W | %4$d°C | %5$.3f km</string>
+ <string name="notification_text_not" translatable="false">%1$.0f km/h | %2$d %% | %3$.0f W | %4$d°C | %5$.3f km</string>
it should be in a separate PR
—
Reply to this email directly, view it on GitHub
<#448 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJTVZQ3C5L52YNVCNRLR7TX3HKYPANCNFSM6AAAAAA46EQVIM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
No description provided.