Removing Unicode EN+Space for Space #106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing Unit Tests
vincentkoc
added a commit
to vincentkoc/Parser-JavaScript
that referenced
this pull request
Jan 20, 2019
Removing references of u\2002 in data files and unit tests. Originally reported on PHP library WhichBrowser/Parser-PHP#96 - And same PR built for PHP ported to JS library WhichBrowser/Parser-PHP#106
vincentkoc
added a commit
to vincentkoc/Parser-JavaScript
that referenced
this pull request
Jan 22, 2019
Removing references of u\2002 in data files and unit tests. Originally reported on PHP library WhichBrowser/Parser-PHP#96 - And same PR built for PHP ported to JS library WhichBrowser/Parser-PHP#106
mariotsi
added a commit
to WhichBrowser/Parser-JavaScript
that referenced
this pull request
Feb 6, 2019
#33) * Removing Unicode EN+Space for Space Removing references of u\2002 in data files and unit tests. Originally reported on PHP library WhichBrowser/Parser-PHP#96 - And same PR built for PHP ported to JS library WhichBrowser/Parser-PHP#106 * Removing Unicode EN+Space for Space Removing references of u\2002 in data files and unit tests. Originally reported on PHP library WhichBrowser/Parser-PHP#96 - And same PR built for PHP ported to JS library WhichBrowser/Parser-PHP#106 * Now update-profiles.js and update-models.js strip away EN+SPACE character as requested on #32 * Revert changes to data files. These files are automatically generated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #96