Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Mini set comparison and volume inclusion #113

Merged
merged 6 commits into from
Oct 14, 2024
Merged

feat: Mini set comparison and volume inclusion #113

merged 6 commits into from
Oct 14, 2024

Conversation

WhyAsh5114
Copy link
Owner

@WhyAsh5114 WhyAsh5114 commented Oct 14, 2024 •
edited
Loading

Description

Include mini-set volume for exercises and show them in comparison component. Fixes #85

Type of change

  • New feature (non-breaking change which adds functionality)

Things to fix

  • Using the compare action button during workouts doesn't show mini-sets
  • Set volume doesn't consider mini-sets
  • Set types which rely on mini-sets might not progress as expected

@vercel Vercel
Copy link

vercel bot commented Oct 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
my-fit-jgqg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 6:45am

@WhyAsh5114 WhyAsh5114 marked this pull request as draft October 14, 2024 05:27
@WhyAsh5114 WhyAsh5114 marked this pull request as ready for review October 14, 2024 06:48
@WhyAsh5114 WhyAsh5114 merged commit ce3129f into main Oct 14, 2024
6 checks passed
@WhyAsh5114 WhyAsh5114 deleted the 85-mini-sets branch October 14, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mini set comparison and volume calculation
1 participant
@WhyAsh5114