Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip rendering text when font size would be zero #218

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

akx
Copy link
Contributor

@akx akx commented Nov 28, 2023

Refs #217

@WhyNotHugo WhyNotHugo merged commit 12148e1 into WhyNotHugo:main Nov 28, 2023
11 checks passed
@WhyNotHugo
Copy link
Owner

Thanks

@WhyNotHugo
Copy link
Owner

Oh, care to add a CHANGELOG entry for this?

@akx
Copy link
Contributor Author

akx commented Nov 28, 2023

@WhyNotHugo Sure thing (though it's not really a change that should be user-facing).

@WhyNotHugo
Copy link
Owner

WhyNotHugo commented Nov 28, 2023

Previously this worked "by coincidence", but now it is fixed and I'd consider it something that can be relied upon.

akx added a commit to akx/python-barcode that referenced this pull request Nov 28, 2023
@akx akx mentioned this pull request Nov 28, 2023
akx added a commit to akx/python-barcode that referenced this pull request Nov 28, 2023
@akx akx deleted the dont-render-zero-size-font branch November 28, 2023 12:05
akx added a commit to akx/python-barcode that referenced this pull request Nov 28, 2023
WhyNotHugo pushed a commit that referenced this pull request Nov 28, 2023
@akx
Copy link
Contributor Author

akx commented Apr 4, 2024

@WhyNotHugo Could we maybe get a release out that'd include this? Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants