Optimization of code creation, avoiding to many charset switch. #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…results in shorter code which according to GS1 spec should not be longer than 165 mm (6.5") 1) For code128, starding encoding set to C 2) Added function that determines whether the char is FNC1 char - defined the same in all three encodings 3) _maybe_switch_charset recognizes that FNC1 char is defined in all three encodings, and avoids changing encodings 4) added testcases for new functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FCN1 char is defined the same in all three encodings. The current implementation switched encodings multiple times, even if the whole code could be created with encoding C. According to GS1 spec the whole barcode (including Quiet Zones) should not be longer than 165 mm (6.5"), thus any additional symbol added to the code resulted in longer code. This PR optimizes the proces of code creation, avoiding encoding switch.