refactor: article graph to use functional component #5498
Conversation
|
Could you add a reference to the relevant issue in your PR? (it makes it easier to track which components have been refactored if each PR references back to issue #5393) |
done |
…a/WikiEduDashboard into articleGraphRefactor
|
@justiceotuya could you resolve conversations as you go along addressing them? Makes it easier to track changes |
Resolved and fixed @TheTrio |
| if (dataIncludesWp10 || !articleData) { | ||
| editSize = null; |
There was a problem hiding this comment.
same here — this hasn’t been fixed and yet the conversation is marked as resolved.
There was a problem hiding this comment.
unresolved and fixed @TheTrio
| if (!dataIncludesWp10 || !articleData) { | ||
| radioInput = null; |
There was a problem hiding this comment.
this isn't required either
There was a problem hiding this comment.
why is this marked as resolved?
There was a problem hiding this comment.
unresolved and fixed @TheTrio
| let radioInput = ( | ||
| <div> | ||
| <div className="input-row"> | ||
| <input |
There was a problem hiding this comment.
missing a check for articleData[0].wp10
There was a problem hiding this comment.
@TheTrio This has been fixed
NOTE: Please review the pull request process before opening your first PR: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/CONTRIBUTING.md#pull-request-process
What this PR does
refactor: article_graph class component to use functional component from this Issue #5393
Screenshots
Screen.Recording.2023-10-04.at.10.56.09.PM.mov