-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to reach specific training modules and slides via ID numbers #5502
Merged
ragesoss
merged 12 commits into
WikiEducationFoundation:master
from
gabina:AddFunctionalityToReachSpecificTrainingModulesAndSlidesViaIDNumbers
Oct 10, 2023
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
dcfd285
Add a new find_training_module route and its corresponding controller…
gabina 75129a5
Small stylistic change in controller
gabina 13705ae
Minor change in controller and addition of new spec for it
gabina edc0873
Add new find_training_slide route and its corresponding controller to…
gabina a626846
Add spec to test new find_slide method in training controller
gabina ef2c7c5
Upload missing file from previous commit
gabina 5918b20
Add a TrainingHelper class to include functions to find 1) a libary f…
gabina a1d2a54
Minor stylistic change
gabina dfcfd8c
Apply RuboCop on the changed files
gabina fbb894f
Stop raising RoutingError for modules that are not in any library. Us…
gabina 54f8848
Remove TrainingHelper module and define methods to find module and li…
gabina 3c2fadc
Define find_or_default_library instance method to avoid code duplicat…
gabina File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,5 +19,8 @@ | |
|
||
FactoryBot.define do | ||
factory :training_slide do | ||
id { 456875} | ||
title { 'How to create a slide' } | ||
slug { 'how-to-create-a-slide' } | ||
end | ||
end | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added this because I want to test the behavior for an orphan slide (one that doesn't belong to any module). |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible to have a module that is not in any library, and it would render if you visited a path that had any valid training library slug. (You can view a module from one library even if you substitute the slug from another library.)
It would be good to find the library as you do here, but if no library is found, it would be better to use TrainingLibrary.first as a fallback instead of throwing a 404.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm interesting. That behavior is not so intuitive I guess.
I changed the logic for the controllers and updated specs on fbb894f
Note that the new definitions may result in failure if no library exists. In such a scenario, calling
TrainingLibrary.first
would returnnil
, causing an error when attempting to access the slug.Not sure if a world with no libraries makes sense, or it is not worth considering this case and we can suppose
TrainingLibrary.first
is always well defined.It looks like modules and slides render even using a non-existing library slug, so we could use a literal string
'mylibrary'
as default library slug value if no libraries at all.What's your opinion here?