Fixed Capybara screenshot feature in broken tests #5657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atulyadav745 did you test this locally? Please post a screenshot from test. (You could do this by adding an explicit error to the middle of a feature spec and then running it.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR addresses the issue #5653 where, in the event of a failing feature test, the code in rails_helper.rb attempts to capture a screenshot using Capybara. However, due to changes in the Capybara screenshot interface, the method call for creating a screenshot results in a NoMethodError. This PR resolves the issue by updating the method call to match the changed Capybara screenshot interface, ensuring that screenshots are successfully generated when a feature spec fails.
Open questions and concerns
@ragesoss please review this pull request and let me know if there are any issues that need to be addressed before it can be merged, or if it is ready to proceed.
Thank You