Improve BlockedUserAlert emails #5795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragesoss
reviewed
Apr 29, 2024
app/mailers/alert_mailer.rb
Outdated
| @@ -19,4 +19,21 @@ def alert(alert, recipient) | |||
| params[:reply_to] = @alert.reply_to unless @alert.reply_to.nil? | |||
| mail(params) | |||
| end | |||
|
|
|||
| def self.send_msg_to_student(alert, recipient) | |||
There was a problem hiding this comment.
I think adding the student and all the instructors to the recipients, rather than sending a separate email to each, is the best way to do this. That way, it can be the beginning of a conversation among the student, the instructors, and the Wiki Education staff member.
There was a problem hiding this comment.
Aaah. I have done a bit complicated code I guess. I will redo it, and will rebase since many things will disappear :)
- a new mailer + new template - a new method in BlockUserAlert to mail to a set of concerned people which replace the current one in blocked_user_monitor.rb - the corresponding spec - new line in preview mailer
cyrillefr
force-pushed
the
Improve_BlockedUserAlert_emails
branch
from
d3b5eb9 to
df6c6f8
Compare
|
I have updated the first comment. I don't know if it is visible or not. |
|
The code of this looks fine to me, but I need to come up with better email content before merging it. I'm working with my team on figuring that part out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Closes issue #5776
On one Alert, need to email to instructors + blocked student
-edited-
which replace the current one in
blocked_user_monitor.rbI have added a template that might not be exactly polished but is a good start.
To be expanded by me or others.