Generic label for Programs & Events Dashboard

[bhushan354]

NOTE: Please review the pull request process before opening your first PR: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/CONTRIBUTING.md#pull-request-process

What this PR does

This PR fixes : #6057
Update link label from 'View Course Page' to 'View Page'

Screenshots

Before:

After:

Open questions and concerns

< anything you learned that you want to share, or questions you're wondering about related to this PR >

[ragesoss]

It looks like this just changes it in all cases. Instead, it needs to switch behavior either based on Course type or based on Features.wiki_ed?. The locale actually already has an entry for the courses_generic version ('View Program Page'), so the necessary change is to use the correct one on Programs & Events Dashboard configuration without affecting the Wiki Education Dashboard configuration.

[bhushan354]

@ragesoss Thanks for the feedback! I’ll update the PR to handle the behavior based on Features.wiki_ed? as you suggested.

[bhushan354]

Hi @ragesoss ,

Is this the program and event dashboard, or the one that appears when we click on the username?

[ragesoss]

@bhushan354 "Programs & Events Dashboard" is outreachdashboard.wmflabs.org, one of two production instances of the Dashboard. The other is Wiki Education Dashboard dashboard.wikiedu.org. The two sites have many behavior differences, mainly controlled by the wiki_education setting in application.yml (which in turn controls Features.wiki_ed?, which is used in the Ruby environment to decide which behavior to use, and Features.wikiEd in the JavaScript environment). So in a dev environment, you need to set that value to false to use Programs & Events Dashboard mode.

[ragesoss]

This is normally handled in the shared _head haml template. I'm not sure what this .erb file is for but I don't think we use it in production. @TheTrio do you remember what this erb file is for? Something needed for Hot Module Reloading from #5354 ? Or maybe it's just an accident and not used for anything?

[ragesoss]

window shouldn't be necessary here, as we normally call Features.wikiEd anywhere in the JS that needs to switch behavior based on this setting.

[ragesoss]

Note that we have a helper function that is built to do this kind of switching: CourseUtils.i18n. It might be that the necessary data is not directly available, but you should check whether the course_string_prefix is part of the JS state already, which will let you use that utility function instead of implementing behavior switch here.

[bhushan354]

I have removed that. Thank you for helping me understand this!

[bhushan354]

@bhushan354 "Programs & Events Dashboard" is outreachdashboard.wmflabs.org, one of two production instances of the Dashboard. The other is Wiki Education Dashboard dashboard.wikiedu.org. The two sites have many behavior differences, mainly controlled by the wiki_education setting in application.yml (which in turn controls Features.wiki_ed?, which is used in the Ruby environment to decide which behavior to use, and Features.wikiEd in the JavaScript environment). So in a dev environment, you need to set that value to false to use Programs & Events Dashboard mode.

Thanks for letting me know , Since the application.yml file has already been set to false, I made the changes while recompiling the webpack. Please let me know if any further enhancements are needed. Thanks !