Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add visual indicator for closed courses #6066

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

swayam-agrahari
Copy link
Contributor

NOTE: Please review the pull request process before opening your first PR: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/CONTRIBUTING.md#pull-request-process

What this PR does

This PR introduces a visual indicator for courses that have been "closed out" by Wiki Education staff.

Screenshots

Before:
image
Screenshot from 2024-12-18 00-41-41

After:

Screenshot from 2024-12-18 00-28-25
Screenshot from 2024-12-18 00-26-17

closes #6050

Open questions and concerns

Please let me know if this works or if further changes are needed!

@ragesoss
Copy link
Member

This looks great! I don't think the 'All review work...' half of the message is needed. Admins who will see this know what 'closed' means.

Showing a 'closed' indication on the campaign view is also a good idea, but I'd prefer leaving that to a separate PR. I will add notes about how that ought to work, on the issue description.

@swayam-agrahari
Copy link
Contributor Author

swayam-agrahari commented Dec 17, 2024

@ragesoss
Thank you for the feedback!
I will remove the "All review work..." sentence as suggested. For the campaign view 'closed' indication, I can handle it in this PR if you'd prefer.
If not, do I need to raise an spearate issue for campaign view,if not included in this pr?
Let me know how you'd like me to proceed!

@ragesoss
Copy link
Member

I prefer a separate PR, but you can mention the same issue for the campaign view.

@swayam-agrahari
Copy link
Contributor Author

swayam-agrahari commented Dec 18, 2024

Hello @ragesoss , I have removed the additional texts and styles from campaign view.
I will make a pr for campain view asap : )

@ragesoss ragesoss merged commit a8b016d into WikiEducationFoundation:master Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easy for Wiki Education staff to see when a course has been closed
2 participants