Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: front end bugs #6070

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Formasitchijoh
Copy link
Contributor

What this PR does

This PR fixes several failing feature tests that were raising ElementNotFound errors. The failures primarily occurred in React-Select components that rely on API requests to fetch and render data. Due to Capybara's short default wait time, tests failed before the data was displayed. This issue was most notable in category_scope_spec.rb but also impacted other minor failures in frontend code, such as scoping_methods_course_creation_spec.rb.

Key Changes Made

  • Increased Capybara's default wait time: To handle delays caused by slow API requests and ensure data is rendered before the test proceeds.
  • Ensured unique keys for course campaigns: Used the CampaignList index to generate unique keys for course campaigns.
  • Handled undefined valid and search values: Addressed these issues in the CourseCreator page to prevent errors.

Files Changed

  • rails_helper.rb
  • campaign_scope_spec.rb
  • course_creator.jsx

Screenshots

Before:
Screenshot 2024-12-19 at 17 14 13

After:
Screenshot 2024-12-19 at 21 25 41

@ragesoss
Copy link
Member

Ooh, this looks like a great set of fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants