Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to NumPy 1.22.* #101

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Upgrade to NumPy 1.22.* #101

merged 3 commits into from
Jul 9, 2024

Conversation

rajadain
Copy link
Member

@rajadain rajadain commented Jul 7, 2024

Overview

This fixes MMW installs because Numba 0.55 is compiled against NumPy 1.22.

This also fixes these messages in MMW:

Unable to import compiled InitSnow_inner, using slower version
Unable to import compiled InitSnowYesterday_inner, using slower version
Unable to import compiled AMC5_yesterday_inner, using slower version
Unable to import compiled CNum_inner, using slower version
Unable to import compiled CNumImper_inner, using slower version
Unable to import compiled CNumPerv_f_inner, using slower version
Unable to import compiled Percolation_inner, using slower version
Unable to import compiled DeepSeep_inner, using slower version
Unable to import compiled AdjUrbanQTotal_inner, using slower version
Unable to import compiled UrbLoadRed_inner, using slower version
Unable to import compiled WashPerv_inner, using slower version
Unable to import compiled WashPerv_inner, using slower version
Unable to import compiled UnsatStor_inner, using slower version
Unable to import compiled DeepSeep_inner, using slower version
Unable to import compiled UnsatStor_inner, using slower version

Closes #100

Testing Instructions

  • Pull the latest version of Upgrade to Ubuntu 22.04, Python 3.10 model-my-watershed#3631
  • Destroy and recreate the app and worker VMs to pull this version of GWLF-E
    vagrant destroy -f app worker && vagrant up
  • Run ./scripts/debugserver.sh
    • Ensure there are no GWLF-E warnings
  • In another terminal window, run ./scripts/debugcelery.sh
    • Ensure there are no GWLF-E warnings
  • Open http://localhost:8000/ and draw an arbitrary shape
  • Run the Watershed Multi Year Model
    • Ensure it completes successfully
    • Ensure there are no warnings in the Celery output

rajadain added 3 commits July 7, 2024 10:24
Numba 0.55.* is compiled against NumPy 1.22.*
Because we were using NumPy 1.21.*, it was
causing a number of compilation and installation
issues.

By switching to the correct version of NumPy,
those are fixed.
This ensures we test the compilation, as well as
run test against the proper compiled version.
Add --dev flag to sync command to ensure dev dependencies are
installed. Also add a build step to ensure AOT compilation is
done.
@rajadain rajadain marked this pull request as ready for review July 7, 2024 15:21
@rajadain rajadain requested a review from rachelekm July 7, 2024 15:21
Copy link

@rachelekm rachelekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success! I'm able to successfully complete the actions in the testing instructions and have no no GWLF-E warnings 👍

@rajadain
Copy link
Member Author

rajadain commented Jul 9, 2024

Thanks for reviewing!

@rajadain rajadain merged commit e7cea30 into develop Jul 9, 2024
2 checks passed
@rajadain rajadain deleted the tt/100/fix-mmw-installs branch July 9, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS 2-4: Fix Installing GWLF-E on MMW
2 participants