Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Python 3.10 #95

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Add Support for Python 3.10 #95

merged 3 commits into from
Jul 3, 2024

Conversation

rajadain
Copy link
Member

@rajadain rajadain commented Jun 28, 2024 •
edited
Loading

Overview

Update dependencies so that gwlf-e works in Python 3.10 environments in addition to Python 3.9.

Closes #94

@rajadain rajadain force-pushed the tt/94/python-3.10 branch from ca1d975 to 286d82a Compare June 28, 2024 02:23
@rajadain rajadain requested a review from rachelekm June 28, 2024 20:05
rajadain added a commit to WikiWatershed/model-my-watershed that referenced this pull request Jun 28, 2024
@rajadain
Upgrade Python to 3.10
79487e8 
Using a branch installation for GWLF-E until WikiWatershed/gwlf-e#95
is published to PyPI.
rajadain added a commit to WikiWatershed/model-my-watershed that referenced this pull request Jul 2, 2024
@rajadain
Upgrade Python to 3.10
718fb3f 
Using a branch installation for GWLF-E until WikiWatershed/gwlf-e#95
is published to PyPI.
rachelekm
rachelekm approved these changes Jul 3, 2024
View reviewed changes
Copy link

@rachelekm rachelekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! I checked out the referenced commit and tested with the initial gwlf-e version, which failed, and then with this branch installation and confirmed this branch succeeded and allowed for a successful installation of dependencies in Python 3.10 env.

@rajadain rajadain merged commit 94efc68 into develop Jul 3, 2024
2 checks passed
@rajadain rajadain deleted the tt/94/python-3.10 branch July 3, 2024 01:23
@rajadain
Copy link
Member Author

rajadain commented Jul 3, 2024

Thanks for reviewing!

rajadain added a commit to WikiWatershed/model-my-watershed that referenced this pull request Jul 3, 2024
@rajadain
Use gwlf-e develop as of WikiWatershed/gwlf-e#95
b64d339
rajadain added a commit to WikiWatershed/model-my-watershed that referenced this pull request Jul 3, 2024
@rajadain
Use gwlf-e develop as of WikiWatershed/gwlf-e#95
48da90a
@rajadain rajadain mentioned this pull request Jul 3, 2024
Merged
7 tasks
rajadain added a commit to WikiWatershed/model-my-watershed that referenced this pull request Jul 10, 2024
@rajadain
Use gwlf-e develop as of WikiWatershed/gwlf-e#95
fb93bdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelekm rachelekm rachelekm approved these changes

Assignees

@rachelekm rachelekm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS 2-4: Add Support for Python 3.10+
2 participants
@rajadain @rachelekm