Downgrade Docker to Fix RWD #3632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous image was published using Docker Image Format 1, which is no longer supported by Docker v26 that comes with Ubuntu 22.04. We switched the RWD to publish to GitHub Container Registry, and updated the base TauDEM image to Ubuntu 16.04, the last version to support Python 2.7.
This reverts commit c2ebf29.
rachelekm
approved these changes
Jul 16, 2024
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The Ubuntu upgrade of #3631 also upgrade Docker to v26, which was incompatible with the old RWD images. For that, we upgraded TauDEM and RWD to the new Docker image format in WikiWatershed/rapid-watershed-delineation#84, WikiWatershed/rapid-watershed-delineation#83, WikiWatershed/docker-taudem#2, WikiWatershed/docker-taudem#1, and WikiWatershed/docker-taudem#5.
Unfortunately, using the new Docker image results in failures recorded here: WikiWatershed/rapid-watershed-delineation#87. Rather than spend more time fixing those, it is easier to downgrade Docker to v25 to work with the old images for now. That's what this PR does.
Closes #3629
Demo
Testing Instructions
Note: this review does not require checking locally, only on staging