Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions #85

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Add GitHub Actions #85

merged 3 commits into from
Jul 11, 2024

Conversation

rajadain
Copy link
Member

@rajadain rajadain commented Jul 10, 2024

Overview

Add GitHub Actions workflows to build this project.

Connects #84

Demo

https://github.com/WikiWatershed/rapid-watershed-delineation/actions/runs/9879012817

Notes

We expect the CI to fail currently because it is built atop the existing TauDEM image, which is really old. We are upgrading that in WikiWatershed/docker-taudem#1, and once that is done, RWD will be upgraded in #83.

Testing Instructions

  • Ensure that CI runs on PRs

Also pause script if RWD_DATA is not set
Remove old Travis CI configuration
uses: docker/login-action@v3
with:
registry: quay.io
username: ${{ secrets.QUAY_USERNAME }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These secrets currently don't exist. We will add them at a later date.

Copy link

@rachelekm rachelekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@rajadain rajadain merged commit cfd32e7 into develop Jul 11, 2024
1 check failed
@rajadain rajadain deleted the tt/84/github-actions branch July 11, 2024 15:24
@rajadain
Copy link
Member Author

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants