Added NULL check before unsubscribing from PasswordChanged (PasswordBindBehaviour) #580
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When working with the
ConnectionStringBuilder
I got a crash every time I closed the window. After some investigation I figured out, that the Problem is thePasswordBindBehaviour
. When the window is closed the password-box is removed and theAssociatedObject
property is set to null before theOnAssociatedObjectUnloaded
method gets called. This results in an exception being thrown.To prevent this I added a NULL check before the unsubscription is done. There should be no problems with memory leaks or lingering connectios even when not explicitly unsubscribing.
API Changes
None
Platforms Affected
Behavioral Changes
None
Testing Procedure
PR Checklist