Fix Fabric hurt sounds requiring the mod server-side #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM although one question: Why was the female hurt translation text removed or is that no longer a requirement? |
This was mentioned in the PR itself:
|
celestialfault
force-pushed
the
fix/hurt-sounds
branch
from
9f7530b to
ce11e6b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds client-sided hurt sounds on Fabric; fixes #83, and supersedes the hurt sound half of #117
An important difference between this and the Forge hurt sound implementation, is that while Forge replaces the hurt sound, this plays over top the vanilla hurt sound; this was done as the vanilla hurt sound may provide important context for how a player is taking damage, which could be especially helpful for players with poor eyesight.
The subtitle was also removed as a result of this playing over top the vanilla sound, as it doesn't provide any extra information that the player wouldn't already have from the vanilla subtitle.