Fix syncing on dedicated servers #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the initial join sync on dedicated servers, as well as various issues around the sync being sent too early (which is most prominent on Quilt), which results in the receiving client crashing This also splits event lambdas into their own functions for readability, and merges PacketSync and PacketGenderInfo to a single WildfireSync class, using PacketGenderInfo (renamed to PacketSync) as the only packet class sent over the network.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #138, #116; supersedes #117
This moves the initial join sync out from the client event class, which resulted in the event never being registered on a dedicated server.
Along with that, this has been changed to sync when a player begins tracking another player, instead of simply fire-hosing sync packets for all connected players to the joining player, which should hopefully further reduce the possibility of issues like #116 appearing again.
Note that I haven't actually been able to test that these changes fully work, beyond starting a dedicated server and ensuring that you can join it (and that the client->server sync appears to be sent and received properly).
PacketSyncandPacketGenderInfohave also been merged into a singleWildfireSyncclass, usingPacketGenderInfo(renamed toPacketSync) as the only packet class sent over the network.This change was made largely due to the changes required on the server-side sending of packets, due to to making use of entity tracking for initial syncing instead, but was also made as I quite simply couldn't properly wrap my head around which class referred to which side.