Cape Textures #256

WildfireRomeo · 2024-12-06T03:38:00Z

Cape implementation from celestialfault's git repo. Not sure if it's 100% done correctly so PR-ing this for now.

WildfireRomeo · 2024-12-08T15:47:19Z

Reopening because I don't believe this is against TOS, will not merge quite yet though.

In my hours of research, I don't see anywhere in the terms of service (from MULTIPLE years viewed by wayback machine) that you CAN'T use a cape for occasional uses.
It only mentions SELLING them as a no-no. I don't see why having a cape for like 5 people would even be a problem in Mojang's eyes. Especially since it's only viewable by people using the mod.

Commercial Usage Guidelines - Apr 2019
YOU MAY:

sell cosmetic items, except for “Capes”, IF the item sold does not give a user an unfair gameplay advantage over anyone else on the server - i.e there can be no “pay to win”.
sell positive effects or enhancements (other than “Capes”) IF everyone on the server is positively affected in exactly the same way.

Servers and hosting - Dec 2024
YOU MAY MAKE MONEY BY

Selling cosmetics, except for capes or anything that attempts to visually act like the feature of a Minecraft player cape

The "Extended functionality and modifications" section (aka mods) has no mention of capes.

If anyone has a direct source of where it says I cannot do that, then I'd be happy to not add this feature, but as it stands it doesn't seem like a problem to me. I think Mojang only has a problem with it if people are making money off of it.

Sources:
https://web.archive.org/web/20190425124840/https://account.mojang.com/terms
https://www.minecraft.net/en-us/usage-guidelines
Not only that, but the cape clauses are under a "Servers and hosting" section. Which has nothing to do with client mods.

Playing Minecraft with others is one of the best ways to play. You may host a server for Minecraft. You may even charge for access to the server as long as you follow the guidelines in this section. By “server,” we mean a single connecting address or IP number.

celestialfault

A few issues I noticed while glancing over this

celestialfault · 2024-12-08T18:10:16Z

src/main/java/com/wildfire/main/cape/CapeProvider.java

+
+    private static final Pattern USERNAME = Pattern.compile("^[a-z0-9_]{1,16}$", Pattern.CASE_INSENSITIVE);
+    private static final String CAPE_URL = "https://femalegendermod.net/capes/{name}.png";
+    private static final String FALLBACK_CAPE_URL = "https://femalegendermod.net/capes/{name}.png";


Redundant fallback url

src/main/java/com/wildfire/main/cape/CapeProvider.java

src/main/java/com/wildfire/mixins/cape/MinecraftClientMixin.java

src/main/java/com/wildfire/mixins/cape/PlayerListEntryMixin.java

src/main/java/com/wildfire/mixins/cape/SkinTexturesMixin.java

src/main/java/com/wildfire/mixins/cape/SkinTexturesWildfireImplMixin.java

celestialfault · 2024-12-08T18:14:09Z

src/main/java/com/wildfire/main/cape/CapeProvider.java

+        }
+    }
+
+    public static void tick() {


This method is never called from the client tick handler

celestialfault · 2024-12-08T18:15:14Z

src/main/java/com/wildfire/main/cape/CapeProvider.java

+    private static final String CAPE_URL = "https://femalegendermod.net/capes/{name}.png";
+    private static final String FALLBACK_CAPE_URL = "https://femalegendermod.net/capes/{name}.png";
+
+    private static void remove(RemovalNotification<GameProfile, CompletableFuture<@Nullable Identifier>> entry) {


This entire destroy queue could probably be removed and just directly destroy the texture upon it being removed from the cache, as this is only a thing due to the reload cape button added in my fork.

Co-authored-by: celeste <[email protected]>

…lMixin.java Co-authored-by: celeste <[email protected]>

Co-authored-by: celeste <[email protected]>

…lMixin.java Co-authored-by: celeste <[email protected]>

- Remove tick() and destroy queue - Change name to uuid - Fixed a few things

celestialfault

Looks good aside from a few very minor issues, but nothing important enough to block this.

celestialfault · 2024-12-08T18:51:40Z

src/main/java/com/wildfire/main/cape/CapeProvider.java

+            Identifier texture = tryUrl(player, CAPE_URL.replace("{uuid}", player.getId().toString()));
+
+            /*if(texture == null) { //fallback url if existed, which it doesn't.
+                texture = tryUrl(player, FALLBACK_CAPE_URL.replace("{uuid}", player.getName()));


This should also use .getId().toString()

celestialfault · 2024-12-08T18:52:47Z

src/main/java/com/wildfire/mixins/cape/SkinTexturesWildfireImplMixin.java

+@Implements(@Interface(iface = SkinTexturesWildfire.class, prefix = "wildfiregender$", unique = true))
+public abstract class SkinTexturesWildfireImplMixin {
+    private @Unique
+    @Nullable Identifier wildfiregender$overriddenCapeTexture = null;


private should be on the same line as the type

WildfireRomeo added 2 commits December 5, 2024 22:37

Cape Textures

10ddec7

Rename kappa namespace

2d2c2f9

WildfireRomeo closed this Dec 6, 2024

celestialfault mentioned this pull request Dec 6, 2024

Add contributor nametags #257

Merged

WildfireRomeo reopened this Dec 8, 2024

celestialfault suggested changes Dec 8, 2024

View reviewed changes

WildfireRomeo and others added 9 commits December 8, 2024 13:19

Update src/main/java/com/wildfire/mixins/cape/MinecraftClientMixin.java

a436806

Co-authored-by: celeste <[email protected]>

Update src/main/java/com/wildfire/mixins/cape/PlayerListEntryMixin.java

bc4949e

Co-authored-by: celeste <[email protected]>

Update src/main/java/com/wildfire/mixins/cape/SkinTexturesWildfireImp…

0b7a653

…lMixin.java Co-authored-by: celeste <[email protected]>

Update src/main/java/com/wildfire/mixins/cape/SkinTexturesMixin.java

d7fc6b9

Co-authored-by: celeste <[email protected]>

Update src/main/java/com/wildfire/mixins/cape/SkinTexturesWildfireImp…

d5d005b

…lMixin.java Co-authored-by: celeste <[email protected]>

Update src/main/java/com/wildfire/mixins/cape/SkinTexturesWildfireImp…

4fdcf95

…lMixin.java Co-authored-by: celeste <[email protected]>

Update src/main/java/com/wildfire/mixins/cape/SkinTexturesWildfireImp…

7687dea

…lMixin.java Co-authored-by: celeste <[email protected]>

Cape modifications

8ab0a29

- Remove tick() and destroy queue - Change name to uuid - Fixed a few things

Remove unnecessary system out println

27e44b1

celestialfault approved these changes Dec 8, 2024

View reviewed changes

Fixes

c668dc4

WildfireRomeo merged commit 9066535 into fabric-1.21.4 Dec 8, 2024
2 checks passed

WildfireRomeo deleted the feature/cape branch December 8, 2024 19:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cape Textures #256

Cape Textures #256

WildfireRomeo commented Dec 6, 2024 •

edited

Loading

WildfireRomeo commented Dec 8, 2024 •

edited

Loading

celestialfault left a comment

celestialfault Dec 8, 2024

celestialfault Dec 8, 2024

celestialfault Dec 8, 2024

celestialfault left a comment

celestialfault Dec 8, 2024

celestialfault Dec 8, 2024

Cape Textures #256

Cape Textures #256

Conversation

WildfireRomeo commented Dec 6, 2024 • edited Loading

WildfireRomeo commented Dec 8, 2024 • edited Loading

celestialfault left a comment

Choose a reason for hiding this comment

celestialfault Dec 8, 2024

Choose a reason for hiding this comment

celestialfault Dec 8, 2024

Choose a reason for hiding this comment

celestialfault Dec 8, 2024

Choose a reason for hiding this comment

celestialfault left a comment

Choose a reason for hiding this comment

celestialfault Dec 8, 2024

Choose a reason for hiding this comment

celestialfault Dec 8, 2024

Choose a reason for hiding this comment

WildfireRomeo commented Dec 6, 2024 •

edited

Loading

WildfireRomeo commented Dec 8, 2024 •

edited

Loading