Halloween holiday feature

[PinguinLars]

Some please make a good halloween mask or something

[celestialfault]

Just a few TODO-ish notes

[celestialfault]

PlayerConfig#holidayThemes should also probably be changed to default to false if this is added, since I feel like this is already a bit much with just the santa hat to apply to every player with only a manual opt-out (including NPC players)

[PinguinLars]

I will look what i can do with my limited coding knowledge. (You should have access to contribute in this pr)

[celestialfault]

I will look what i can do with my limited coding knowledge.

You don't have to make any of these changes, they're more just // TODO comments I wanted to point out

(You should have access to contribute in this pr)

That checkbox only applies to collaborators with push access to the upstream repository

[PinguinLars]

That checkbox only applies to collaborators with push access to the upstream repository

I know that is why i did it by the fork.

[WildfireRomeo]

I might have a texture for a mask I can use from the old Advanced Skin Customization mod.

[WildfireRomeo]

PlayerConfig#holidayThemes should also probably be changed to default to false if this is added, since I feel like this is already a bit much with just the santa hat to apply to every player with only a manual opt-out (including NPC players)

If I'm honest, I kinda disagree. I feel like no one would notice it or even try to use it if it's disabled by default. It's easy for people to go into the mod and disable it if they don't want it enabled, and it's only for 3 days of the entire year (currently).

I've said before I have different plans for this feature eventually (i.e. able to select certain basic cosmetics to equip in a separate menu), but as of right now I'm leaving it as is.

If there's a way to disable it for NPC players by default, I might do that.

[celestialfault]

I feel like no one would notice it or even try to use it if it's disabled by default.

Note that I only explicitly mentioned PlayerConfig - meaning that it'd still be set to the config default of true through Configuration whenever that's loaded, and would simply mean that it wouldn't affect players that don't have a configuration.

I'd also be open to simply making this default value a separate (enabled by default) global config option though, but I'm generally just not a fan of having these apply to all player entities currently, with no way to remove them on NPCs.

If there's a way to disable it for NPC players by default, I might do that.

While there isn't a universal method to determine if a player entity is an NPC, you could generally get a pretty good idea by checking UUID#version() - most large servers tend to use other UUID versions for their NPCs, while actual players always have a UUID version of 4.

[PinguinLars]

Works again now

[celestialfault]

These should probably have different messages, although if vanilla rendering code throws an error we probably have bigger issues

[celestialfault]

These probably just shouldn't be wrapped in try/catch blocks entirely, tbh.

[PinguinLars]

What would be better the current time span or only the thirty first?

[WildfireRomeo]

Wrong button, didn't mean to request a review oops...