Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dep exports for IFTPipeline #316

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Conversation

cpaniaguam
Copy link
Member

@cpaniaguam cpaniaguam commented Jul 5, 2023

Re-exporting HDF5, PyCall, Dates, DataFrames for IFTPipeline.

@cpaniaguam cpaniaguam requested a review from tdivoll July 5, 2023 18:29
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (97cf1ba) 55.27% compared to head (a4d7886) 55.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   55.27%   55.27%           
=======================================
  Files          71       71           
  Lines        4617     4617           
=======================================
  Hits         2552     2552           
  Misses       2065     2065           
Impacted Files Coverage Δ
src/IceFloeTracker.jl 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cpaniaguam cpaniaguam force-pushed the feat-export-deps-for-pipeline branch from 9c33a26 to 930c986 Compare July 6, 2023 15:47
tdivoll
tdivoll previously approved these changes Jul 6, 2023
Copy link
Collaborator

@tdivoll tdivoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe swap the test back to run all tests?

@cpaniaguam cpaniaguam requested a review from tdivoll July 6, 2023 17:13
@cpaniaguam cpaniaguam merged commit fe71353 into main Jul 7, 2023
@cpaniaguam cpaniaguam deleted the feat-export-deps-for-pipeline branch July 7, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants