Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main Menu toggle Show/Hide #2509

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Main Menu toggle Show/Hide #2509

merged 3 commits into from
Nov 8, 2024

Conversation

lededev
Copy link
Contributor

@lededev lededev commented Oct 29, 2024

Now we can have the simplest user interface, suitable for keyboard-centric power users and small screen users, maximizing the content display area.
The hotkey to show and hide the main menu is Shift+F12. You can also right-click on the title bar or left-click on the system menu icon to select from the system menu. Even with the main menu hidden, the main menu also works normally. For example, pressing Alt+F will bring up the File menu, Alt+E will bring up the Edit menu, and Alt+V will bring up the View menu. So there are other ways to restore the main menu, such as pressing (Alt+Space, H) or (Alt+V, H) or (F10, V, H).

Here is the display effect after hiding the main menu, tab bar, toolbar, diff pane and status bar:
image
image
image
image

@sdottaka
Copy link
Member

Thank you for the PR.
When the menu bar is hidden, pressing Alt+F etc. displays the menu, but it feels a bit strange.
Is it possible to make the menu bar appear when you press the Alt key like in other applications?
Also, I'm being very careful about adding shortcut keys these days.
I'd like to avoid adding shortcut keys if possible.

@lededev
Copy link
Contributor Author

lededev commented Nov 4, 2024

(Alt+Space, U) or (Alt+V, U) or (F10, V, U)
image

@sdottaka
Copy link
Member

sdottaka commented Nov 4, 2024

Great! I'll check it out later.

@sdottaka sdottaka merged commit 8cb4c33 into WinMerge:master Nov 8, 2024
3 checks passed
@sdottaka
Copy link
Member

sdottaka commented Nov 8, 2024

This PR has been merged. Thank you for the PR!
I plan to make the following modifications to this PR.

  • Change the "Main Menu" menu item to "Menu Bar" to match the other menu items.
  • Change the registry setting name from "Settings/HideMainMenu" to "Settings/ShowMenubar".
  • Move the location of method definitions and change some method names.
  • When the menu bar is set to hidden, pressing Alt+F will display the menu bar, but pressing the right key multiple times in that state will cause the menu bar to hide and then reappear, which is an unnatural behavior, so we will improve this.

sdottaka added a commit that referenced this pull request Nov 8, 2024
Marcellomco added a commit to Marcellomco/winmerge that referenced this pull request Nov 9, 2024
Added translation for "Main Menu toggle Show/Hide (WinMerge#2509) (2)"
@Marcellomco Marcellomco mentioned this pull request Nov 9, 2024
sdottaka pushed a commit that referenced this pull request Nov 9, 2024
Added translation for "Main Menu toggle Show/Hide (#2509) (2)"
@sdottaka sdottaka added this to the v2.16.45.0 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants