Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caret (text cursor) follow windows settings #2534

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

lededev
Copy link
Contributor

@lededev lededev commented Nov 11, 2024

The current text cursor width is hard coded to 2, which is too thin to be noticeable on HiDPI displays. It was changed to the value from Windows Control Panel for text cursor, allowing users to adjust it.

@sdottaka sdottaka merged commit 1d7aa13 into WinMerge:master Nov 11, 2024
3 checks passed
@sdottaka
Copy link
Member

Thank you for the PR. It has been merged.
However, even in an environment where the DPI is 200%, when I execute SystemParametersInfo (SPI_GETCARETWIDTH, 0, &caretWidth, 0);, caretWidth is set to 1. I think it is probably necessary to take DPI into account, so I plan to fix this later.

@sdottaka sdottaka added this to the v2.16.45.0 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants