BLUAlert Additional Features #2314
Conversation
Adding February items to the slips lib.
Slips lib update
Hi, I expanded the "Validate inventory" function. Normally it just works on a single repository (your inventory). I modified so you can do it on any repository, one at a time. Validate wardrobe3, validate safe, validate storage etc. It's updated with the newest additions of Wardrobes5-8. If you use a custom Lua that includes all the Sets from all your jobs lua, you can basically check one repository at a time to find items that are present in those repositories but no longer present in any lua, i.e. items you no longer use. It's basically a tool to clean up repositories from items you no longer use but are not aware of. Multiple people have been using this tool but until now it required to temporarily overwrite the default validate with my custom one, then restore the original one after you're done with the cleaning. Implemeting these changes in the basic Validate.lua would make this step no longer necessary. More detailed info on how it works can be find in the related FFXIAH thread https://www.ffxiah.com/forum/topic/54596/custom-gearswap-validate-to-clean-up-inventory/#3495138 There is one thing I'm unsure of. I originally developed this custom lua several years ago, and I recently updated it adding Wardrobe5-8. This means the original Validate.lua I used as a core for my custom might have been older than the current Validate.lua Someone more competent than me would need to doublecheck that I didn't miss any important (new) feature in my custom version. Shouldn't take long, I didn't really add too many lines to the original code in the end. Thanks for your time.
Updated indentation for better reading
fixed indentation some more >_>
Update validate.lua
Fixing for aoe ws skillschains reporting all targets and not just the one that effectively got the skillchain. Reported on issue Windower#2154
[Battlemod] Fix for aoe ws skillchains
Gearswap Validate syntax fix
Dev -> Live
equipviewer validate bags fix
Wardrobe Fix
Dev -> Live
Gearswap Wardrobe inventories fix fix
Dev -> Live 2022/02/18 Fix
Gearswap Motes increase macro books
Dev -> Live
update digger messages for 2022-03
pointwatch - automatically update message IDs
Add in "magic eva" to cover items like Nyame Sollerets which wasn't capturing magic evasion
Update checkparam.lua
The gametime addon will not load correctly on Lightningday due to a check only looking for the pluralised form.
Update gametime.lua to resolve issue with loading on Lightningday
make it possible to access text settings again
Adding items from the July 10, 2023 update.
[Slips] Update for July 10, 2023 items
This change fixes an issue where itemizer would fail to locate HQ items, whose name ended with "+1", "+2" etc, because was treating the the +x at the end of the string as the amount argument instead.
Added `find` argument and corresponding functionality to search song names for a provided string.
# Conflicts: # addons/GearSwap/helper_functions.lua # addons/GearSwap/user_functions.lua # addons/libs/slips.lua
[Addon][translate] Fix for allowing blocked messages through
The `find` argument will print a notice if no matching songs are found.
Update setbgm.lua
Update setbgm.lua
August 2023 Update for the Slips library.
Adding Slip 31 id
Replaced the tts voice with creative commons sound effects.
|
I'm down to merge this after you modify the |
I'd be happy to! I'll make the change ASAP. Thanks! Edit: Hit the wrong button, did not mean to close this. |
| @@ -76,6 +73,7 @@ function get_action_id(targets) | |||
| end | |||
| end | |||
|
|
|||
| -- Register the action event listener | |||
There was a problem hiding this comment.
This comment doesn't really add much info that isn't immediately obvious from the next line - I would remove it.
| -- Plays a sound when Blue Magic is learned | ||
| windower.register_event('incoming text', function(original, modified, original_mode, modified_mode, blocked) | ||
| -- Check if the modified message contains "learns" followed by a Blue Magic spell name | ||
| local spell_name = modified:match("learns%s+(.+)!") |
There was a problem hiding this comment.
I'd also add a %s+ in front of the learns string. Furthermore, this should match the original text, not the modified one. It's possible some addon modifies what the text looks like and changes the learns word (for example, something like: "Spell learned: "), then it would no longer match it. Using original should make it work reliably in any case.
Finally, I'd also add a check for the original_mode. Otherwise it would trigger even when someone writes something in a party chat, for example.
There was a problem hiding this comment.
I would not change this file, but instead add a new one, and let users choose which to pick via the settings.
|
While you're at it, if you could halve the volume of the original sound effect that would also be great ^_^; |
|
Thanks for all the feedback! I'll get to work on these changes ASAP. Totally makes sense to make it a setting so it's an optional change. I hate the tts voice so I hadn't considered that someone would be unhappy to see it changed, but you're right that it ought to be an opt-in. Will modify it soon! |
Hi! This is a version of BLUAlert I adjusted for my own use, but I thought it offered some nice features that make it worth merging.
Firstly, the addon now plays a sound both when an unknown blue magic spell is used, as well as when the player learns a spell. That way, you don't have to keep a close eye on the chat log or keep your blue magic menu open to verify that you're done learning the spell.
Secondly, I replaced the default text to speech voice that notifies you when unknown blue magic has been used with a Creative Commons-licensed sound effect, as well as another CC sound effect for when you learn a spell.
Finally, I adjusted the readme to account for the new feature, and bumped the version number up to 1.1.0.
Thanks a bunch! Please let me know if you have any questions or comments.