-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shortcuts] add support for items #2354
Open
Traelblaser
wants to merge
1,550
commits into
Windower:dev
Choose a base branch
from
Traelblaser:shortcuts-items
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cal-clock-drift Add Vana Time offset
Co-authored-by: RubenatorX <[email protected]>
…mestamp_fix [gearswap] Fix buff duration calculation in packet_parsing.lua
Added items to slips libs for the 10 May, 2022 FFXI Update.
[Slips lib] Update for May 2022
I checked in Selbina and the arrival times are correct. https://cdn.discordapp.com/attachments/484050756169760788/978709336333361222/unknown.png
[gametime] fix //gt route
Trusts: Fix for player party member out-of-zone
Dev -> Live
Add items for June 2022 Update
Added DIKs for f13-f15.
DIKs for f11 & f12
Yush.lua updated DIKs
Yush: Added a VerboseKeys setting to enable key display in each macro set.
Bugfix in the new iterator
…gmatch and string.sub (Windower#2336)
Updating new items for the slips lib
Adding Esoteric Athame and Eyre Cap to Storage slips 22
* Update send.lua Adjust string processing to reinstate double quotes removed by the command processor. * Update send.lua * Update send.lua Spaces after commas. * Update send.lua Fixed an oversight around the `<tid>` functionality. * Update send.lua Added toggle command for the debug functionality. * Update send.lua * Update send.lua Rename dbg to debug
* Update send.lua Initial refactoring by Arcon * Update send.lua Tentative fix for a couple quirks caused by splitting the `target` arg off `...` * Update send.lua Added obligatory `<on|off>` argument to `@debug` Moved debug prints around for simplicity Fixed bugs: - a stray `:upper()` had survived the refactoring - a `@job` target that was different from the sender main job would be lost in the void and not passed on * Update send.lua
(Libs/Packets) Fixed 0x00A field typo
… of true master level under level sync without removing synced master level option
[pointwatch] support the display of true ML under level sync
Preserve numerical values for spell.skill and spell.element as they're potentially useful in multiple scenarios, most often when comparing stuff against resources
Fix issue with scrolls and indi plates colliding with spells
Cleaned up debug statements Removed some duplicates with kneel/laugh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for items to the shortcuts addon
Supersedes and Closes #2076
Some test cases:
/drieddate1
will eat a dried date +1/drieddate
will eat a dried date/drieddate+1
will eat a dried date +1other food should work as above, though I did not test every single food. Food with +2 or +3 might be interesting to test, but I didn't have any.
/fire5
still works (regression in the inherited code)most other spells already worked
/warp
still functions with e.g. selindrile's warp command/remedy
eats a remedy/instant warp
will eat an instant warp scoll/instant reraise
will eat an instane reraiseDispensable items aren't supported by this e.g. REMA guns, other stuff like that.