Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shortcuts] add support for items #2354

Open
wants to merge 1,550 commits into
base: dev
Choose a base branch
from

Conversation

Traelblaser
Copy link

@Traelblaser Traelblaser commented May 5, 2024

Add support for items to the shortcuts addon
Supersedes and Closes #2076

Some test cases:
/drieddate1 will eat a dried date +1
/drieddate will eat a dried date
/drieddate+1 will eat a dried date +1
other food should work as above, though I did not test every single food. Food with +2 or +3 might be interesting to test, but I didn't have any.

/fire5 still works (regression in the inherited code)
most other spells already worked
/warp still functions with e.g. selindrile's warp command
/remedy eats a remedy
/instant warp will eat an instant warp scoll
/instant reraise will eat an instane reraise
Dispensable items aren't supported by this e.g. REMA guns, other stuff like that.

Byrth and others added 30 commits May 13, 2022 06:25
…mestamp_fix

[gearswap] Fix buff duration calculation in packet_parsing.lua
Added items to slips libs for the 10 May, 2022 FFXI Update.
[Slips lib] Update for May 2022
Trusts: Fix for player party member out-of-zone
Added DIKs for f13-f15.
DIKs for f11 & f12
Yush: Added a VerboseKeys setting to enable key display in each macro set.
lili-ffxi and others added 29 commits February 14, 2024 14:29
Bugfix in the new iterator
Updating new items for the slips lib
Adding Esoteric Athame and Eyre Cap to Storage slips 22
* Update send.lua

Adjust string processing to reinstate double quotes removed by the command processor.

* Update send.lua

* Update send.lua

Spaces after commas.

* Update send.lua

Fixed an oversight around the `<tid>` functionality.

* Update send.lua

Added toggle command for the debug functionality.

* Update send.lua

* Update send.lua

Rename dbg to debug
* Update send.lua

Extensive code revision
Added two new targets: @party and @zone

* Update send.lua

All commas are now properly married to a space each

* Update send.lua

Removed all trailing spaces
* Update send.lua

Initial refactoring by Arcon

* Update send.lua

Tentative fix for a couple quirks caused by splitting the `target` arg off `...`

* Update send.lua

Added obligatory `<on|off>` argument to `@debug`
Moved debug prints around for simplicity
Fixed bugs:
- a stray `:upper()` had survived the refactoring
- a `@job` target that was different from the sender main job would be lost in the void and not passed on

* Update send.lua
(Libs/Packets) Fixed 0x00A field typo
… of true master level under level sync without removing synced master level option
[pointwatch] support the display of true ML under level sync
Preserve numerical values for spell.skill and spell.element as they're potentially useful in multiple scenarios, most often when comparing stuff against resources
Fix issue with scrolls and indi plates colliding with spells
Cleaned up debug statements
Removed some duplicates with kneel/laugh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.