Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
익명 게시판인 경우에만 salt값을 포함한 암호화 진행하도록 수정.
회원탈퇴한 작성자가 쓴 게시글, 댓글, 쪽지 조회 시 "(알수없음)" 처리 추가 회원탈퇴한 사용자의 프로필 조회 시 404 에러 리턴
LeeJE20
approved these changes
Aug 21, 2023
| @@ -68,8 +65,8 @@ public MessageResponseWithRecipentDto getListByRoom(Long roomId, int page, int s | |||
|
|
|||
| return MessageResponseWithRecipentDto.of( | |||
| AES256Util.encrypt(recipient.getMemberId().toString()), | |||
| profile.getImage(), | |||
| recipient.getSchoolName(), | |||
| recipient.isDeleted() ? null : profileService.getProfile(recipient.getMemberId()).getImage(), | |||
There was a problem hiding this comment.
가급적 반영해 주세요!
클린코드에서 값이 없을때 null을 보내는 것보다는 "", 빈 배열, 빈 리스트 등의 빈 값을 보내는 것을 더 지향합니다!
There was a problem hiding this comment.
@LeeJE20 반영했습니다!
null 대신 "", 빈 배열, 빈 리스트 등을 사용하는 이유는 NullPointerException이 발생할 가능성이 있기 때문인가요?!
| profile.getImage(), | ||
| recipient.getSchoolName(), | ||
| recipient.isDeleted() ? null : profileService.getProfile(recipient.getMemberId()).getImage(), | ||
| recipient.isDeleted() ? "(알수없음)" : recipient.getSchoolName(), |
There was a problem hiding this comment.
반영해도 좋고 안 해도 좋습니다.
"(알수없음)"을 여러 군데에서 쓰고 있네요. 상수화 해서 사용해도 좋을 것 같습니다.
There was a problem hiding this comment.
@LeeJE20 상수화하고 싶었는데 어느 위치에 만들어 놓아야 할지 애매해서 일단 literal string으로 썼습니다,,🥲
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 체크리스트
📋 변경 유형
✏️ PR 개요
-- PR 확인 --
article, comment, util 폴더 제외하고 그 밑으로 봐주면 됨!
resolved: #261