Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ProtoBuf mapping.json #1236

Merged
merged 5 commits into from
Jan 26, 2025
Merged

Fix ProtoBuf mapping.json #1236

merged 5 commits into from
Jan 26, 2025

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Jan 9, 2025

close #1233

@StefH StefH added the bug label Jan 9, 2025
@StefH StefH self-assigned this Jan 9, 2025
@StefH StefH changed the title Fix ProtoBuf Mappings Fix ProtoBuf mapping.json Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 72.59259% with 37 lines in your changes missing coverage. Please review.

Project coverage is 36.91%. Comparing base (888d913) to head (1da7316).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...reMock.Net/Server/WireMockServer.ConvertMapping.cs 78.00% 11 Missing ⚠️
src/WireMock.Net/Util/PortUtils.cs 64.51% 11 Missing ⚠️
src/WireMock.Net/RequestBuilders/Request.cs 60.00% 6 Missing ⚠️
...eMock.Net/ResponseBuilders/Response.WithHeaders.cs 0.00% 3 Missing ⚠️
src/WireMock.Net/Util/ProtoDefinitionHelper.cs 85.71% 2 Missing ⚠️
...t/Matchers/Helpers/BodyDataMatchScoreCalculator.cs 75.00% 1 Missing ⚠️
src/WireMock.Net/ResponseBuilders/Response.cs 80.00% 1 Missing ⚠️
src/WireMock.Net/Serialization/MatcherMapper.cs 66.66% 1 Missing ⚠️
src/WireMock.Net/Server/RespondWithAProvider.cs 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1236      +/-   ##
==========================================
+ Coverage   35.11%   36.91%   +1.79%     
==========================================
  Files         203      230      +27     
  Lines       33366    41450    +8084     
==========================================
+ Hits        11718    15303    +3585     
- Misses      21095    25451    +4356     
- Partials      553      696     +143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StefH StefH merged commit ed07da7 into master Jan 26, 2025
14 checks passed
@StefH StefH deleted the stef-1233-proto-mapping-file-json branch January 26, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GRPC mappings are not created correctly when created through Admin API
1 participant