Fix loading and improvements

Wirecloud · Jan 12, 2024 · 04e702f · 04e702f
1 parent f46fca1
commit 04e702f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 15 deletions.
diff --git a/src/wirecloud/platform/static/js/wirecloud/Widget.js b/src/wirecloud/platform/static/js/wirecloud/Widget.js
@@ -312,18 +312,24 @@
             // If this is a v2 or later widget, we need to instantiate it's entrypoint class
             _unloadScripts.call(this);
             _loadScripts.call(this).then(() => {
-                const entrypoint = eval("window[\"" + this.meta.entrypoint + "\"]");
+                const entrypoint = window[this.meta.entrypoint];
                 if (entrypoint === undefined) {
                     this.logManager.log("Widget entrypoint class not found!", {console: false});
                 } else {
                     this.widgetClass = Wirecloud.createAPIComponent("widget", this.meta.requirements, entrypoint,
                         this.wrapperElement.shadowRoot, this.id,
                         ('workspaceview' in this.tab.workspace.view) ? this.tab.workspace.view.workspaceview : undefined);
                 }
+
+                privates.get(this).status = STATUS.RUNNING;
+
+                this.pending_events.forEach(send_pending_event, this);
+                this.pending_events = [];
+
+                this.dispatchEvent('load');
             });
         }
 
-        privates.get(this).status = STATUS.RUNNING;
         if (this.meta.macversion > 1) {
             this.wrapperElement.addEventListener('unload', on_unload.bind(this), true);
         } else {
@@ -340,11 +346,6 @@
                 level: Wirecloud.constants.LOGGING.INFO_MSG
             });
         }
-
-        this.dispatchEvent('load');
-
-        this.pending_events.forEach(send_pending_event, this);
-        this.pending_events = [];
     };
 
     const on_unload = function on_unload() {

diff --git a/src/wirecloud/platform/static/js/wirecloud/wiring/Operator.js b/src/wirecloud/platform/static/js/wirecloud/wiring/Operator.js
@@ -203,17 +203,22 @@
             this.wrapperElement.contentDocument.defaultView.addEventListener('unload', on_unload.bind(this), true);
         } else if (!this.meta.missing && this.meta.macversion > 1) {
             // If this is a v2 or later operator, we need to instantiate it's entrypoint class
-            const entrypoint = eval("window[\"" + this.meta.entrypoint + "\"]");
+            const entrypoint = window[this.meta.entrypoint];
             if (entrypoint === undefined) {
                 this.logManager.log("Operator entrypoint class not found!", {console: false});
             } else {
                 this.operatorClass = Wirecloud.createAPIComponent("operator", this.meta.requirements, entrypoint,
                     undefined, this.id,
                     ('workspaceview' in this.wiring.workspace) ? this.wiring.workspace.workspaceview : undefined);
             }
-        }
 
-        privates.get(this).status = STATUS.RUNNING;
+            privates.get(this).status = STATUS.RUNNING;
+
+            this.pending_events.forEach(send_pending_event, this);
+            this.pending_events = [];
+
+            this.dispatchEvent('load');
+        }
 
         if (this.missing) {
             this.logManager.log(utils.gettext("Failed to load operator."), {
@@ -225,11 +230,6 @@
                 level: Wirecloud.constants.LOGGING.INFO_MSG
             });
         }
-
-        this.dispatchEvent('load');
-
-        this.pending_events.forEach(send_pending_event, this);
-        this.pending_events = [];
     };
 
     const on_unload = function on_unload() {