Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove django relatives and django appconf #546

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

dmunozv04
Copy link
Contributor

@dmunozv04 dmunozv04 commented Jun 20, 2024

Proposed changes

This PR removes django-relatives since the only function Wirecloud uses from it can be replaced with a builtin django option. It also removes django-appconf from requirements.txt since it wasn't used (a dependency uses it but not the main Wirecloud package)

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@dmunozv04 dmunozv04 changed the title Remove django relatives Remove django relatives and django appconf Jun 20, 2024
@coveralls
Copy link

Coverage Status

coverage: 88.256%. first build
when pulling 1f640fe on dmunozv04:remove-django-relatives
into b197d37 on Wirecloud:develop.

@aarranz aarranz merged commit 590a739 into Wirecloud:develop Jun 27, 2024
36 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants