Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only compile the files needed #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

staugaard
Copy link

There is no reason to compile all of the WiringPi library.

This change makes sure that we only compile the files that we need.

@staugaard
Copy link
Author

This is my first time working on a gem that has a c extension, so I'm not exactly sure that what I'm doing here is right.

I know it sounds strange but I would like be able to compile the gem locally on my laptop.

I'm working on a gem (staugaard/rupi) that used wiringpi when run on the raspberrypi, but the gem is also to be used locally on your laptop while you develop the your application. In order to make your gem compile locally we need to make sure that we don't compile more than we need.

One other thing that we need to change is the 0b0000 style contrants that you have in WiringPi.c as this is not supported be the old version (4.2) of gcc that apple supplies on my laptop.

Do you think we could do this?

@Gadgetoid
Copy link
Member

This makes sense, but I'm not sure how much of the base WiringPi library I should actually change. I'm happy to maintain a version that's parallel, but not identical, to Gordon's and merge his changes in manually when they happen, but only if it's going to be of real significant benefit.

Fortunately, I think it's probably worth doing as we've had fixes to WiringPi already which may not necessarily make their way into Gordon's original version. In for a penny, in for a pound!

I will investigate your changes. I'm no expert in what I'm doing here, either, it's more for my own educational benefit than anything else, so I'm receptive to any help/input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants