prebuild for Node on macOS+arm64 and Windows+ia32 #1002
Conversation
|
I was copying your code for a different repo (tree-sitter/node-tree-sitter#128) and noticed that you don't do this. |
verhovsky
force-pushed
the
prebuild-node-archs
branch
from
ac2ffff to
f44ee25
Compare
verhovsky
changed the title
|
+1 |
verhovsky
changed the title
|
@mceachen Can this get reviewed? Mac arm builds are no longer being pre-built for regular darwin (only electron darwin). |
|
+1 I think this would fix #1027 as well. |
|
Let's get this merged! This doesn't add any code, just compile flags. Should be an easy job! |
|
This would be so great to get working! |
|
Would be amazing if this got reviewed |
|
(Sorry I missed this PR, thanks!) |
|
Did this PR get reverted? I'm seeing recompiles happen on |
|
What Node version are you using? It didn't get reverted. The correct files for macOS arm64 are there on the GitHub Release although the release CI failed to run |
I am running I notice there are node binaries for node |
|
Node 18.7.1 is NODE_MODULE_VERSION 108 |
This switches from the commonjs require() syntax to the newer ESM import syntax. Jest did not work with the ESM syntax, so I updated the Jest config to use esbuild to transpile the ESM syntax to commonjs, so Jest can still run the tests. We do this in the main CO2.js package, to it seemed an ok precedent to follow. This also updates better-sqlite, to use a new version which seems to offer pre-builds, as of #1002 on the better sqlite repo. WiseLibs/better-sqlite3#1002
No description provided.