Added export functionality for mp3's #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stall with npm. Updated both pngquant and canvas, pngquant now includes a binary with their more recent versions which means less requirements to compile.
- Making it possible to specify a version you want to try to export as - Making it possible to turn on/off different log levels - Preparing for the possibility of LZMA file compression, a rare format - Passing Versioning info deeper into the parsing mechanism, and streaming, so that versions can be used to circumvent problems in different decoding methods.
…rse streamed mp3 files but I couldn't find any swf examples of this, leaving the code here in hopes it will help in future commits. Temporarily storing Audio bytes in parser.js and saving them to disk in index.js's _extractClassGroup(). I assume there is a better place for this, I need to understand the index.js _processFileGroup() code a bit more.
…ed below the dashes. Also gave it a purpose. While we may not know what the binary is, it could still be relevant for the parsing. In my test cases, I had a newer project which the company had stored the mp3 as a binary file, this is a common way to store things in a swf. I changed it to output all binaries with a .binary ending, and let them try to guess what they are. Also fixing up some of my code to more properly adhere to the standards, returning onData and centralizing the data logging.
…but I guessed an appropriate number change based on previous commits. Updated readme to show how to get more documentation as user, and swf format link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feature request #4, I've gone ahead and made the base system for exporting audio. My test use cases included 4 SWF files I found from quite a few years ago, each a different use case of the SWF format. The ones with sound used MP3's, so I was unable to test the other formats, but more than likely they would be very similar to the MP3 way. Just a binary data dump onto the harddrive. But without a way to test easily I left those for another day.
A side effect is that all binaries also get exported now, and may be hard for users to know how to handle.