-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Audio.music" system with music overriding #77
Open
SpencerlyEverly
wants to merge
14
commits into
WohlSoft:master
Choose a base branch
from
SpencerlyEverly:audio-music-switching
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
"Audio.music" system with music overriding #77
SpencerlyEverly
wants to merge
14
commits into
WohlSoft:master
from
SpencerlyEverly:audio-music-switching
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… support for getting the currently playing music and SFX
…tart on events for SFXs (onSFXStart)
… system though...
… function anyway...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am back with a new pull request! Here's a new addition that goes great with "Audio.sounds": "Audio.music"!
Basically, the system for SFXs have been ported over to now include music. Below is information on how it works, along with code that will need to be added to SMBX2 itself:
Music Category IDs
Track IDs
Depending on the category ID, track IDs are the music IDs located under "music.ini".
New Functions
Audio.music[musicCategoryID][trackID].music
Audio.music[musicCategoryID][trackID].music = musicFilepath
SMBX2 Lua Code to Add
As for what should be added to SMBX2's Lua side for this to work, check out the codes I wrote for "main.lua" and "classexpander.lua" here: https://pastebin.com/v9tb3vGt
Conclusion
This system is useful for changing the Special Music and World Music in Lua, since changing music in those categories are either possible (World Music filepaths, but it needs extra Lua code to make it possible), or actually impossible outside of this pull request (Special Music filepaths, which can't be changed outside of editing music.ini)
So, there's the answer on how useful this will be.
Hopefully, this pull request gets accepted at some point in time!