Use two new sniffs from PHPCSExtra 1.2.0 #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPCSExtra 1.2.0 was released yesterday and contains two new sniffs which IMO would be suitable for adding to WordPressCS. Includes raising the minimum supported PHPCSExtra version. (will conflict with PR 2408 and will need rebase depending on which is merged first) Ref: * https://github.com/PHPCSStandards/PHPCSExtra/releases/tag/1.2.0
GaryJones
approved these changes
Dec 3, 2023
dingo-d
approved these changes
Dec 3, 2023
|
@dingo-d As you've now merged this, this means that the next release will have to be the 3.1.0 release, so I've moved what was merged so far in the |
|
Yup that is fine with me, we shouldn't block new releases (this one wasn't a draft so it's better to merge it sooner than later imo). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPCSExtra 1.2.0 was released yesterday and contains two new sniffs which IMO would be suitable for adding to WordPressCS.
Includes raising the minimum supported PHPCSExtra version. (will conflict with PR #2408 and will need rebase depending on which is merged first)
Ref:
--
Note: adding these sniffs means this PR will need to go into a new minor, while #2408 can go into a patch release.