Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a ServerSideRender block example. #130

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Add a ServerSideRender block example. #130

merged 2 commits into from
Oct 25, 2024

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Oct 22, 2024

Fixes #129

This PR adds a simple block that utilizes ServerSideRender.

@ndiego ndiego added the example: new A new example request label Oct 22, 2024
@ndiego ndiego self-assigned this Oct 22, 2024
@flexseth
Copy link
Contributor

Thanks for adding, Nick. I'd love to see an ELI5 for SSR and the benefits/drawbacks/why-to for SSR!

Excellent work as always, sir.

ryanwelcher
ryanwelcher approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@ryanwelcher ryanwelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! I had one question that may be a good addition to the Readme but it's not a blocker for me.

@ndiego ndiego merged commit 387c51b into trunk Oct 25, 2024
3 checks passed
@ndiego ndiego deleted the add-server-side-render-block-example branch October 25, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanwelcher ryanwelcher ryanwelcher approved these changes

Assignees

@ndiego ndiego

Labels
example: new A new example request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an example that utilizes ServerSideRender
3 participants
@ndiego @flexseth @ryanwelcher