-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WooCommerce demo blueprint with custom flat rate shipping and pro… #62
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
@calvinrodrigues500 thank you for working on this PR! I like that it shows how to set up a WooCommerce shop with a custom product and shipping. Would it be also possible to set up some form of payment method like Direct Bank Transfers? This would allow users to fully experience the checkout flow. |
@bgrgicak Thank you for your feedback! I'll work on adding a payment method to provide a complete checkout experience. |
@@ -0,0 +1,165 @@ | |||
<?xml version="1.0" encoding="UTF-8" ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the default WooCommerce product import be a better fit for this?
It has more products with all standard types (simple, variable) and would make testing of WooCommerce easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@calvinrodrigues500 what do you think about using the default WooCommerce product import here?
Thanks for the changes @calvinrodrigues500! I wasn't initially sure if this should be a separate demo or could be added to existing demos, but the more I think about it, this is a really good minimal WooCommerce setup for testing. |
Co-authored-by: Bero <[email protected]>
@bgrgicak Thanks for the feedback! I'm glad the setup works well for testing. If there's anything else you'd like me to adjust or improve, feel free to let me know. |
@bgrgicak I have updated the code to use default WC products XML. |
"step": "importWxr", | ||
"file": { | ||
"resource": "url", | ||
"url": "https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/sample-data/sample_products.xml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's include this file in this PR, the idea is to avoid referencing external resources. See https://github.com/WordPress/blueprints/blob/trunk/CONTRIBUTING.md
"path": "/wordpress/wp-content/plugins/woo-shipping-method/woo-shipping-method.php", | ||
"data": { | ||
"resource": "url", | ||
"url": "https://raw.githubusercontent.com/calvinrodrigues500/blueprints/woo-shipping/blueprints/woo-shipping/woo-shipping-method/woo-shipping-method.php" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's include this file in this PR, the idea is to avoid referencing external resources. See https://github.com/WordPress/blueprints/blob/trunk/CONTRIBUTING.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamziel
Sorry for the delay in responding.
I’m a bit unclear about the approach to updating the URLs. Should I point them to https://raw.githubusercontent.com/WordPress/blueprints/... now, even though this would cause errors when testing the blueprint in a playground until the PR is merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah no, I only meant to have this file included in the PR, which I now see it was – perhaps I got confused when reviewing :-) Either way, it looks good now, thank you for proposing this Blueprint!
Thank you @calvinrodrigues500! I left a few notes about the resource origin. Also, running the Blueprint via the preview link yields this error: You may want to use the raw.githubusercontent.com domain instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes @calvinrodrigues500!
WooCommerce Custom Flat Rate Shipping Demo Blueprint