Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add theme reset section #687

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Add theme reset section #687

merged 5 commits into from
Aug 1, 2024

Conversation

matiasbenedetto
Copy link
Contributor

@matiasbenedetto matiasbenedetto commented Jul 9, 2024 •
edited
Loading

What?

Add theme reset section

Why?

Closes: #686 #494

Screencast

Screencast.from.09-07-24.16.37.50.webm

Testing instructions:

  1. make changes to theme templates using the site editor.
  2. make changes to theme template parts using the site editor.
  3. make changes to theme global styles using the site editor.
  4. save the changes in the editor.
  5. use the CBT reset functionality and check that the theme customization was erased.

@matiasbenedetto matiasbenedetto added the enhancement New feature or request label Jul 9, 2024
@matiasbenedetto matiasbenedetto mentioned this pull request Jul 9, 2024
Closed
@mikachan mikachan linked an issue Jul 10, 2024 that may be closed by this pull request
Ability to reset theme style settings #494
Closed
mikachan
mikachan reviewed Jul 10, 2024
View reviewed changes
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testing well for me, nice work 🙌 I've left some minor comments and tiny wording suggestions.

src/editor-sidebar/reset-theme.js Outdated Show resolved Hide resolved
src/editor-sidebar/reset-theme.js Outdated Show resolved Hide resolved
src/editor-sidebar/reset-theme.js Outdated Show resolved Hide resolved
includes/class-create-block-theme-api.php Outdated Show resolved Hide resolved
@matiasbenedetto matiasbenedetto requested a review from mikachan July 11, 2024 11:56
mikachan
mikachan approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is ready to bring in 🎉

@mikachan mikachan merged commit ee2392c into trunk Aug 1, 2024
2 checks passed
@mikachan mikachan deleted the add/theme-reset branch August 1, 2024 10:25
@MaggieCabrera MaggieCabrera mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikachan mikachan mikachan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Create Block Theme Release Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to reset all settings in one click Ability to reset theme style settings
2 participants
@matiasbenedetto @mikachan