fix warning

WordPress · Sep 9, 2024 · 3e948cc · 3e948cc
1 parent c053a9a
commit 3e948cc
Showing 1 changed file with 27 additions and 33 deletions.
diff --git a/packages/edit-site/src/components/post-fields/index.js b/packages/edit-site/src/components/post-fields/index.js
@@ -14,7 +14,6 @@ import {
 	useState,
 	useCallback,
 	useRef,
-	useEffect,
 } from '@wordpress/element';
 import { dateI18n, getDate, getSettings } from '@wordpress/date';
 import {
@@ -146,11 +145,16 @@ function PostAuthorField( { item } ) {
 	);
 }
 
-function FeaturedImage( { item, viewType, getFeaturedMediaUrl } ) {
+function FeaturedImage( { item, viewType } ) {
 	const mediaId = item.featured_media;
 
-	const media = getFeaturedMediaUrl( mediaId );
-
+	const media = useSelect(
+		( select ) => {
+			const { getEntityRecord } = select( coreStore );
+			return getEntityRecord( 'root', 'media', mediaId );
+		},
+		[ mediaId ]
+	);
 	const url = media?.source_url;
 	const title = media?.title?.rendered;
 
@@ -217,19 +221,14 @@ function usePostFields( viewType ) {
 	const { records: authors, isResolving: isLoadingAuthors } =
 		useEntityRecords( 'root', 'user', { per_page: -1 } );
 
-	const { frontPageId, postsPageId, getFeaturedMediaUrl } = useSelect(
-		( select ) => {
-			const { getEntityRecord } = select( coreStore );
-			const siteSettings = getEntityRecord( 'root', 'site' );
-			return {
-				frontPageId: siteSettings?.page_on_front,
-				postsPageId: siteSettings?.page_for_posts,
-				getFeaturedMediaUrl: ( id ) =>
-					getEntityRecord( 'root', 'media', id ),
-			};
-		},
-		[]
-	);
+	const { frontPageId, postsPageId } = useSelect( ( select ) => {
+		const { getEntityRecord } = select( coreStore );
+		const siteSettings = getEntityRecord( 'root', 'site' );
+		return {
+			frontPageId: siteSettings?.page_on_front,
+			postsPageId: siteSettings?.page_for_posts,
+		};
+	}, [] );
 
 	const fields = useMemo(
 		() => [
@@ -238,16 +237,20 @@ function usePostFields( viewType ) {
 				label: __( 'Featured Image' ),
 				type: 'image',
 				render: ( { item } ) => (
-					<FeaturedImage
-						item={ item }
-						viewType={ viewType }
-						getFeaturedMediaUrl={ getFeaturedMediaUrl }
-					/>
+					<FeaturedImage item={ item } viewType={ viewType } />
 				),
 				Edit: ( { field, onChange, data } ) => {
 					const { id } = field;
 
-					const value = field.getValue( { item: data } ) ?? '';
+					const value = field.getValue( { item: data } );
+
+					const media = useSelect(
+						( select ) => {
+							const { getEntityRecord } = select( coreStore );
+							return getEntityRecord( 'root', 'media', value );
+						},
+						[ value ]
+					);
 
 					const onChangeControl = useCallback(
 						( newValue ) =>
@@ -257,22 +260,13 @@ function usePostFields( viewType ) {
 						[ id, onChange ]
 					);
 
-					const media = getFeaturedMediaUrl( value );
-
 					const url = media?.source_url;
 					const title = media?.title?.rendered;
 					const filename =
 						media?.media_details?.file?.match( '([^/]+$)' )[ 0 ];
 
 					const ref = useRef( null );
 
-					// Focus to the media upload button when the component mounts.
-					useEffect( () => {
-						if ( ref.current ) {
-							ref.current.focus();
-						}
-					}, [] );
-
 					return (
 						<fieldset className="edit-site-dataviews-controls__featured-image">
 							<div className="edit-side-dataviews-controls__featured-image-container">
@@ -565,7 +559,7 @@ function usePostFields( viewType ) {
 				],
 			},
 		],
-		[ authors, getFeaturedMediaUrl, viewType, frontPageId, postsPageId ]
+		[ authors, viewType, frontPageId, postsPageId ]
 	);
 
 	return {